fix(tool): trigger fallback on empty task output#29048
Open
niStee wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
niStee
force-pushed
the
fix/trigger-fallback-on-empty-task-output
branch
from
431f76b to
723f91c
Compare
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29054
Type of change
What does this PR do?
When a task completes with no text output (e.g., model was rate-limited or returned an empty response), the
TaskToolnow throws a descriptive error instead of silently returning an empty string. This ensures that downstream consumers (like the fallback system) can properly detect the failure and retry with the next configured model.How did you verify your code works?
Tested locally by simulating an empty output response from a task and verifying that the fallback chain correctly intercepted the failure and retried with the next model.
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist